Conversation
Fixes issue where there is no directory found, due to all-module-sets dir created inside Atlas dir.
Author
|
I've just seen that there was a previous PR closed for this, but no clear explanation? This fixes the error? |
|
Atlas is intended to only run one gamemode at a time, having all 4 of the sets loaded at a single time may cause game-breaking issues. |
Author
|
I've updated this, so it only makes the folder all-module-sets in the plugins directory, then when the server is loaded the user can then drop in the module they want. This should prevent those errors triggering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where there is no directory found, due to all-module-sets dir created inside Atlas folder. Makes it easier to run this repo "out of the box" as users don't have to manually recreate this folder